Skip to content

Remove logger #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 7, 2023
Merged

Remove logger #19

merged 5 commits into from
Sep 7, 2023

Conversation

cristidragomir97
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Sep 7, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Memory usage change @ 7d96459

Board flash % RAM for global variables %
arduino:mbed_opta:opta 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board extras/tests/TestExisting
flash		 % extras/tests/TestExisting
RAM for global variables		 % extras/tests/TestFileOperations
flash		 % extras/tests/TestFileOperations
RAM for global variables		 % extras/tests/TestFolderOperations
flash		 % extras/tests/TestFolderOperations
RAM for global variables		 % extras/tests/TestRepeatedFormatMount
flash		 % extras/tests/TestRepeatedFormatMount
RAM for global variables		 % extras/tests/TestUnified
flash		 % extras/tests/TestUnified
RAM for global variables		 % examples/SimpleStorageWriteRead
flash		 % examples/SimpleStorageWriteRead
RAM for global variables		 % examples/AdvancedUSBInternalOperations
flash		 % examples/AdvancedUSBInternalOperations
RAM for global variables		 % examples/BackupInternalPartitions
flash		 % examples/BackupInternalPartitions
RAM for global variables		 %
arduino:mbed_opta:opta 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,extras/tests/TestExisting<br>flash,%,extras/tests/TestExisting<br>RAM for global variables,%,extras/tests/TestFileOperations<br>flash,%,extras/tests/TestFileOperations<br>RAM for global variables,%,extras/tests/TestFolderOperations<br>flash,%,extras/tests/TestFolderOperations<br>RAM for global variables,%,extras/tests/TestRepeatedFormatMount<br>flash,%,extras/tests/TestRepeatedFormatMount<br>RAM for global variables,%,extras/tests/TestUnified<br>flash,%,extras/tests/TestUnified<br>RAM for global variables,%,examples/SimpleStorageWriteRead<br>flash,%,examples/SimpleStorageWriteRead<br>RAM for global variables,%,examples/AdvancedUSBInternalOperations<br>flash,%,examples/AdvancedUSBInternalOperations<br>RAM for global variables,%,examples/BackupInternalPartitions<br>flash,%,examples/BackupInternalPartitions<br>RAM for global variables,%
arduino:mbed_opta:opta,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Memory usage change @ 96d8f45

Board flash % RAM for global variables %
arduino:mbed_opta:opta 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board extras/tests/TestExisting
flash		 % extras/tests/TestExisting
RAM for global variables		 % extras/tests/TestFileOperations
flash		 % extras/tests/TestFileOperations
RAM for global variables		 % extras/tests/TestFolderOperations
flash		 % extras/tests/TestFolderOperations
RAM for global variables		 % extras/tests/TestRepeatedFormatMount
flash		 % extras/tests/TestRepeatedFormatMount
RAM for global variables		 % extras/tests/TestUnified
flash		 % extras/tests/TestUnified
RAM for global variables		 % examples/SimpleStorageWriteRead
flash		 % examples/SimpleStorageWriteRead
RAM for global variables		 % examples/AdvancedUSBInternalOperations
flash		 % examples/AdvancedUSBInternalOperations
RAM for global variables		 % examples/BackupInternalPartitions
flash		 % examples/BackupInternalPartitions
RAM for global variables		 %
arduino:mbed_opta:opta 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,extras/tests/TestExisting<br>flash,%,extras/tests/TestExisting<br>RAM for global variables,%,extras/tests/TestFileOperations<br>flash,%,extras/tests/TestFileOperations<br>RAM for global variables,%,extras/tests/TestFolderOperations<br>flash,%,extras/tests/TestFolderOperations<br>RAM for global variables,%,extras/tests/TestRepeatedFormatMount<br>flash,%,extras/tests/TestRepeatedFormatMount<br>RAM for global variables,%,extras/tests/TestUnified<br>flash,%,extras/tests/TestUnified<br>RAM for global variables,%,examples/SimpleStorageWriteRead<br>flash,%,examples/SimpleStorageWriteRead<br>RAM for global variables,%,examples/AdvancedUSBInternalOperations<br>flash,%,examples/AdvancedUSBInternalOperations<br>RAM for global variables,%,examples/BackupInternalPartitions<br>flash,%,examples/BackupInternalPartitions<br>RAM for global variables,%
arduino:mbed_opta:opta,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Memory usage change @ 28a6454

Board flash % RAM for global variables %
arduino:mbed_opta:opta 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
Click for full report table
Board extras/tests/TestExisting
flash		 % extras/tests/TestExisting
RAM for global variables		 % extras/tests/TestFileOperations
flash		 % extras/tests/TestFileOperations
RAM for global variables		 % extras/tests/TestFolderOperations
flash		 % extras/tests/TestFolderOperations
RAM for global variables		 % extras/tests/TestRepeatedFormatMount
flash		 % extras/tests/TestRepeatedFormatMount
RAM for global variables		 % extras/tests/TestUnified
flash		 % extras/tests/TestUnified
RAM for global variables		 % examples/SimpleStorageWriteRead
flash		 % examples/SimpleStorageWriteRead
RAM for global variables		 % examples/AdvancedUSBInternalOperations
flash		 % examples/AdvancedUSBInternalOperations
RAM for global variables		 % examples/BackupInternalPartitions
flash		 % examples/BackupInternalPartitions
RAM for global variables		 %
arduino:mbed_opta:opta 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
Click for full report CSV 
Board,extras/tests/TestExisting<br>flash,%,extras/tests/TestExisting<br>RAM for global variables,%,extras/tests/TestFileOperations<br>flash,%,extras/tests/TestFileOperations<br>RAM for global variables,%,extras/tests/TestFolderOperations<br>flash,%,extras/tests/TestFolderOperations<br>RAM for global variables,%,extras/tests/TestRepeatedFormatMount<br>flash,%,extras/tests/TestRepeatedFormatMount<br>RAM for global variables,%,extras/tests/TestUnified<br>flash,%,extras/tests/TestUnified<br>RAM for global variables,%,examples/SimpleStorageWriteRead<br>flash,%,examples/SimpleStorageWriteRead<br>RAM for global variables,%,examples/AdvancedUSBInternalOperations<br>flash,%,examples/AdvancedUSBInternalOperations<br>RAM for global variables,%,examples/BackupInternalPartitions<br>flash,%,examples/BackupInternalPartitions<br>RAM for global variables,%
arduino:mbed_opta:opta,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Memory usage change @ ae9a74b

Board flash % RAM for global variables %
arduino:mbed_opta:opta 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 💚 -192 - 0 -0.01 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board extras/tests/TestExisting
flash		 % extras/tests/TestExisting
RAM for global variables		 % extras/tests/TestFileOperations
flash		 % extras/tests/TestFileOperations
RAM for global variables		 % extras/tests/TestFolderOperations
flash		 % extras/tests/TestFolderOperations
RAM for global variables		 % extras/tests/TestRepeatedFormatMount
flash		 % extras/tests/TestRepeatedFormatMount
RAM for global variables		 % extras/tests/TestUnified
flash		 % extras/tests/TestUnified
RAM for global variables		 % examples/SimpleStorageWriteRead
flash		 % examples/SimpleStorageWriteRead
RAM for global variables		 % examples/AdvancedUSBInternalOperations
flash		 % examples/AdvancedUSBInternalOperations
RAM for global variables		 % examples/BackupInternalPartitions
flash		 % examples/BackupInternalPartitions
RAM for global variables		 %
arduino:mbed_opta:opta 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 0.0 0 0.0 -192 -0.01 0 0.0 -192 -0.01 0 0.0 -192 -0.01 0 0.0 -192 -0.01 0 0.0 0 0.0 0 0.0 -192 -0.01 0 0.0 -192 -0.01 0 0.0
Click for full report CSV 
Board,extras/tests/TestExisting<br>flash,%,extras/tests/TestExisting<br>RAM for global variables,%,extras/tests/TestFileOperations<br>flash,%,extras/tests/TestFileOperations<br>RAM for global variables,%,extras/tests/TestFolderOperations<br>flash,%,extras/tests/TestFolderOperations<br>RAM for global variables,%,extras/tests/TestRepeatedFormatMount<br>flash,%,extras/tests/TestRepeatedFormatMount<br>RAM for global variables,%,extras/tests/TestUnified<br>flash,%,extras/tests/TestUnified<br>RAM for global variables,%,examples/SimpleStorageWriteRead<br>flash,%,examples/SimpleStorageWriteRead<br>RAM for global variables,%,examples/AdvancedUSBInternalOperations<br>flash,%,examples/AdvancedUSBInternalOperations<br>RAM for global variables,%,examples/BackupInternalPartitions<br>flash,%,examples/BackupInternalPartitions<br>RAM for global variables,%
arduino:mbed_opta:opta,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,0,0.0,0,0.0,-192,-0.01,0,0.0,-192,-0.01,0,0.0,-192,-0.01,0,0.0,-192,-0.01,0,0.0,0,0.0,0,0.0,-192,-0.01,0,0.0,-192,-0.01,0,0.0

@sebromero sebromero self-requested a review September 7, 2023 12:30
sebromero
sebromero approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@sebromero sebromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cristidragomir97 cristidragomir97 merged commit c6c3c22 into main Sep 7, 2023
@cristidragomir97 cristidragomir97 deleted the remove_logger branch September 7, 2023 12:32
@per1234 per1234 added topic: documentation Related to documentation for the project topic: code Related to content of the project itself labels Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebromero sebromero sebromero approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself topic: documentation Related to documentation for the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cristidragomir97 @CLAassistant @sebromero @per1234